Node ACK issue

Daniele · 21 May 2018, 20:19

Hi,
I'm quite new to arduino & mysensors, so please be patient if I made any stupid mistake.

I'm trying to leverage the ack functionality in order to be sure my actuator receives mycontroller messages (I'm actually controlling a pair of relays).

The code is simple, and works well without ack.
When I enable ack on the GW (a simple ethernet gw built with an Arduino UNO + W5100), the first 2 messages work fine, the 3rd is received (I can see it in the serial monitor) but the controller never receives the ack (which the node tells to have sent).

From that point on, the node results offline until I reset it.

This is the code I'm using, please give me any idea on how to debug it because I tried anything I could think about:

// Enable debug prints to serial monitor
#define MY_DEBUG

// Enable and select radio type attached
#define MY_RADIO_NRF24
#define MY_RF24_PA_LEVEL   RF24_PA_MIN
#define MY_RF24_DATARATE   RF24_250KBPS
#define MY_RF24_CHANNEL 125

#define MY_NODE_ID 1

#define CHILD_ID_RELAY 2

#define relayPin 5
#define ledPin 6
#define ventolePin 7

#define RELAY_ON 1  // GPIO value to write to turn on attached relay
#define RELAY_OFF 0 // GPIO value to write to turn off attached relay

#include <MySensors.h>

unsigned int relay;
unsigned int new_msg = 0;
//unsigned int last_relay = -1;



void before()
{
  pinMode(ledPin, OUTPUT);
  pinMode(relayPin, OUTPUT);
  pinMode(ventolePin, OUTPUT);

  // Set relay to last known state (using eeprom storage)
  relay = loadState(CHILD_ID_RELAY)?RELAY_ON:RELAY_OFF;
  digitalWrite(ledPin, relay);
  digitalWrite(relayPin, relay);
  digitalWrite(ventolePin, relay);
}


void setup() {
}



void presentation()
{
  sendSketchInfo("P0 - PIR Caldaia", "1.2");
  present(CHILD_ID_RELAY, S_BINARY, "P0 Consenso Caldaia");
}



void loop() {

//  if (relay != last_relay){
  if (new_msg == 1){
    
    digitalWrite(ledPin, relay);
    digitalWrite(relayPin, relay);
    digitalWrite(ventolePin, relay);

    saveState(CHILD_ID_RELAY, relay);
    //last_relay = relay;
    new_msg = 0;

    #ifdef MY_DEBUG
    Serial.print("Relay: ");
    Serial.println(relay);
    #endif
    
  }

  wait(500);

}




void receive(const MyMessage &message)
{
  #ifdef MY_DEBUG
  Serial.println("*** Receiving ***");
  #endif

  
  if (message.type == V_STATUS && message.sensor == CHILD_ID_RELAY) {

    relay = message.getBool()?RELAY_ON:RELAY_OFF;
    new_msg = 1;

  }

}

jkandasa · 22 May 2018, 04:00

@daniele

Do you see any error in MyController log(logs/mycontroller.log) file? Can you give version details of MyController and MySensors. I never get a chance to test ethernet gateway fully with ack feature. If you have serial or MQTT gateway can you give a try to narrow down the issue?

Daniele · 23 May 2018, 20:02

Sorry fot the late response.
This is what I see in the log when the connection breaks:

2018-05-23 22:00:26,524 INFO [mc-th-pool-9] [org.mycontroller.standalone.provider.EngineAbstract:228] Seems like failed to send this message. There is no ACK received! Retried 3 time(s). MessageImpl(gatewayId=3, nodeEui=1, sensorId=2, type=Set, subType=Status, ack=1, payload=1, isTxMessage=true, timestamp=1527105625011, properties=null)
2018-05-23 22:00:35,260 INFO [mc-th-pool-9] [org.mycontroller.standalone.provider.EngineAbstract:228] Seems like failed to send this message. There is no ACK received! Retried 3 time(s). MessageImpl(gatewayId=3, nodeEui=1, sensorId=2, type=Set, subType=Status, ack=1, payload=0, isTxMessage=true, timestamp=1527105633732, properties=null)

Just one more detail I forgot: the node and the GW are really close during this tests (more or less 2 meters of air).

Daniele · 23 May 2018, 20:16

I did another experiment: I defined a dummy sensor, and every time I receive a new message, I push the value I received on this dummy sensor.
In this case, even with the ack turned off, after 5 or 6 status changes the node goes offline.
Seems like the continuous exchange of messages hangs something after a while.

PS: I only have an ethernet GW, sincce the position where I have my Raspberry with Mycontroller is not easily reachable with wireless connection.

jkandasa · 24 May 2018, 14:22

@daniele Dummy sensor attached with dummy node? If yes, it is expected behavior(as dummy node does not response for node alive check).

I do not have ethernet GW at this time. I will try to set up locally.

Do you have only one node or more than one? If more than one, same behavior across all the nodes?
Next time when it goes offline, can you reboot your GW alone and check everything comes normal?

Daniele · 24 May 2018, 14:31

@jkandasa dummy sensor on the same real node, disabling ack on the GW (please look at commented lines in the code):

// Enable debug prints to serial monitor
#define MY_DEBUG

// Enable and select radio type attached
#define MY_RADIO_NRF24
#define MY_RF24_PA_LEVEL   RF24_PA_MIN
#define MY_RF24_DATARATE   RF24_250KBPS
#define MY_RF24_CHANNEL 125

#define MY_NODE_ID 1

#define CHILD_ID_RELAY 2
//#define CHILD_ID_RELAY_C 3

#define relayPin 5
#define ledPin 6
#define ventolePin 7

#define RELAY_ON 1  // GPIO value to write to turn on attached relay
#define RELAY_OFF 0 // GPIO value to write to turn off attached relay

#include <MySensors.h>

//MyMessage msgRELAY(CHILD_ID_RELAY_C, V_STATUS);


unsigned int relay;
unsigned int new_msg = 0;



void before()
{
  pinMode(ledPin, OUTPUT);
  pinMode(relayPin, OUTPUT);
  pinMode(ventolePin, OUTPUT);

  // Set relay to last known state (using eeprom storage)
  relay = loadState(CHILD_ID_RELAY)?RELAY_ON:RELAY_OFF;
  digitalWrite(ledPin, relay);
  digitalWrite(relayPin, relay);
  digitalWrite(ventolePin, relay);
}


void setup() {
}



void presentation()
{
  sendSketchInfo("P0 - PIR Caldaia", "1.2");
  present(CHILD_ID_RELAY, S_BINARY, "P0 Consenso Caldaia");
  //present(CHILD_ID_RELAY_C, S_BINARY, "P0 Consenso Check");
}



void loop() {

  if (new_msg == 1){
    
    digitalWrite(ledPin, relay);
    digitalWrite(relayPin, relay);
    digitalWrite(ventolePin, relay);

    saveState(CHILD_ID_RELAY, relay);
    //send(msgRELAY.set(relay));
    new_msg = 0;

    #ifdef MY_DEBUG
    Serial.print("Relay: ");
    Serial.println(relay);
    #endif
    
  }

  wait(500);

}




void receive(const MyMessage &message)
{
  #ifdef MY_DEBUG
  Serial.println("*** Receiving ***");
  #endif

  
  if (message.type == V_STATUS && message.sensor == CHILD_ID_RELAY) {

    relay = message.getBool()?RELAY_ON:RELAY_OFF;
    new_msg = 1;

  }

}

I have more than one node, but just another is an actuator, and is connected to a different ethernet GW (and it seems to be much more stable, even if not 100%).

I'll try to reboot the GW and let you know the result.

jkandasa · 24 May 2018, 17:34

@daniele Thank you for the update. After implemented ack feature, I never tested ethernet gateway. I will do it when I get time. Kindly update your findings. It might help us to narrow down the issue.

Daniele · 25 May 2018, 20:19

Apparently nothing changes if I reboot the ethernet GW, the node remains disconnected.

jkandasa · 29 May 2018, 07:18

@daniele looks like the problem on node side.

Daniele · 29 May 2018, 07:29

I fully agree with you, but I cannot understand what can be causing the issue.
On the software side, do you suggest any change on the node code?
Could it be an hardware issue?
I tried changing both the arduino and the NRF24, but without any luck.
I tried switching from the 3.3V pin to the 5V pin with a voltage regulator, but still the same issue.

jkandasa · 30 May 2018, 04:24

@daniele Can you try with a different version of MySensors library? What the current version of MySensor library?

Daniele · 30 May 2018, 12:14

I'm using version 2.2.0, which is the last one.

jkandasa · 31 May 2018, 11:40

@daniele ok, When I get time, I will try to reproduce this locally.

Tag · 6 Jan 2018, 22:36

@daniele said in Node ACK issue:

pinMode(ledPin, OUTPUT);
pinMode(relayPin, OUTPUT);
pinMode(ventolePin, OUTPUT);

// Set relay to last known state (using eeprom storage)
relay = loadState(CHILD_ID_RELAY)?RELAY_ON:RELAY_OFF;

Hi!,

Might not be an issue, however from a code perspective you should set the stuff below in the setup loop:

 pinMode(ledPin, OUTPUT);
  pinMode(relayPin, OUTPUT);
  pinMode(ventolePin, OUTPUT);

  // Set relay to last known state (using eeprom storage)
  relay = loadState(CHILD_ID_RELAY)?RELAY_ON:RELAY_OFF;

Before() is called prior to setup... not sure if this really is an issue, but just try it...

What might help is the example from the mysensors site. It contains an example to control relays:
https://www.mysensors.org/build/relay

It does basically the same you want... can you try the example?

Daniele · 3 Jun 2018, 12:08

That's exactly the example I started with, then I changed it trying to avoid this issue (basically I only change the value of a variable during the receive() function to reduce the time needed to process a new message).

I also tried using the setup() instead of the before(), but the effect is the same.

Daniele · 27 Jun 2018, 08:41

@jkandasa , the ack issue is probably related to some hardware interference, not to your code.

Yesterday as a last test I turned off a wireless thermostat I have close to arduino (working on 433 Mhz, so really far from the 2.4 GHz I use with NRF24), and the disconnections suddenly disappeared!

I'm sorry I bothered you.
Thank you very much for your support!
Daniele

jkandasa · 27 Jun 2018, 10:54

@daniele no worries. I am happy that you find the root cause of the issue

Node ACK issue

0

623

531

3.4k