MyController 1.2.0-SNAPSHOT version with major provider changes and supports for ack
-
Need volunteers to test 1.2.0-SNAPSHOT version. This version has major changes on the provider side.
Now it supportsack
.Report your issues here
CAUTION: This version might have major bugs, do not use it in your production environment.
Do backup your existing version and move to this version.Changes: https://github.com/mycontroller-org/mycontroller/commit/67b4f148ea36cd37d917d7560ffaed35871d2b6a
Remove following directory, if you do the dirty upgrade:
# rm mycontroller/conf/persistent_stores/mc/* -rf
To enable ack, edit gateway and,
To see gateway
Statistics
go to gateway details: -
Excellent!
I will test. -
Sign me up! I will test!
---===[ UPDATE ]===---
Houston, we got lift off, all systems go
Now i check my logs and find lots of these:
2018-02-06 19:02:36,966 INFO [mc-th-pool-5] [org.mycontroller.standalone.provider.EngineAbstract:209] Retry count 1 of 3 2018-02-06 19:02:43,865 INFO [mc-th-pool-5] [org.mycontroller.standalone.provider.EngineAbstract:209] Retry count 1 of 3 2018-02-06 19:02:44,372 INFO [mc-th-pool-5] [org.mycontroller.standalone.provider.EngineAbstract:209] Retry count 2 of 3 2018-02-06 19:02:44,885 INFO [mc-th-pool-5] [org.mycontroller.standalone.provider.EngineAbstract:209] Retry count 3 of 3 2018-02-06 19:02:45,409 INFO [mc-th-pool-5] [org.mycontroller.standalone.provider.EngineAbstract:209] Retry count 1 of 3 2018-02-06 19:02:45,924 INFO [mc-th-pool-5] [org.mycontroller.standalone.provider.EngineAbstract:209] Retry count 2 of 3 2018-02-06 19:02:46,436 INFO [mc-th-pool-5] [org.mycontroller.standalone.provider.EngineAbstract:209] Retry count 3 of 3 2018-02-06 19:02:47,084 INFO [mc-th-pool-5] [org.mycontroller.standalone.provider.EngineAbstract:209] Retry count 1 of 3 2018-02-06 19:02:57,479 INFO [mc-th-pool-5] [org.mycontroller.standalone.provider.EngineAbstract:209] Retry count 1 of 3
How to figure out what is going on here?
- What is being re-tried?
- Why is it being re-tried?
-
@tag When you enable
ack
gateway will wait forack
from MySensors. If there is noack
sending again. This will try until it reaches it isFailed retry count
. We have configured these settings in Gateway configuration.Are you Controller and MySensors set-up on the same network? Increase
Ack wait time
, sometimes it will help.I will add more detailed log here, to show what is going on.
Thank you! I will update you once I put these changes.
-
-
I'd like to do some testing too!
I have 2 ethernet gateways, but this new versions seems to have some issue with GW presentation (I still haven't enabled ack on GW): -
-
You're super-quick!!!
I updated the version, and now the issue is fixed.
For the time being everything is running fine, I'll let it run for a pair of days and let you know if I find any issue.By the way, I suggest adding something in this page to expose the ack flag status:
-
PS: really minor issue: the order of the dashboards is reversed now; is there a way to change it?
-
PS: really minor issue: the order of the dashboards is reversed now; is there a way to change it?
There is a change in dashboard, from this fix -> https://github.com/mycontroller-org/mycontroller/issues/424
Do you see anything different? It should be
order by ascending alphabetical
-
By the way, I suggest adding something in this page to expose the ack flag status:
You mean ack enabled or disabled? Or something else?
-
@jkandasa That's exactly what's happening, I missed that change. Thanks!
-
@jkandasa Actually without going in edit you don't have anything telling you if this GW uses ack. Enabled / disabled would be enough for me.
-
@daniele said in MyController 1.2.0-SNAPSHOT version with major provider changes and supports for ack:
@jkandasa Actually without going in edit you don't have anything telling you if this GW uses ack. Enabled / disabled would be enough for me.
Changes updated in SNAPSHOT build.
changes: https://github.com/mycontroller-org/mycontroller/commit/0e7467e230927b67d8f664476f83e2f509d69010 -
When registering nodes with a sensor of the "Motion" type in the old version of MyController, I created two variables "V_ARMED" and "V_TRIPPED". In the new version, only a variable of the type "V_TRIPPED" is created
I'm still looking error in my sketch -
Earlier, when I changed the variable "Armed" on a sleeping node
MyController waited until the node came out of sleep and sent it the right message.
Now when I try to change this variable, I get the following warning
-
When registering nodes with a sensor of the "Motion" type in the old version of MyController, I created two variables "V_ARMED" and "V_TRIPPED". In the new version, only a variable of the type "V_TRIPPED" is created
I guess the problem will be your node sketch presentation code?
-
@wanvo said in MyController 1.2.0-SNAPSHOT version with major provider changes and supports for ack:
MyController waited until the node came out of sleep and sent it the right message.
Now when I try to change this variable, I get the following warningYes, I changed this approach as follows,
If you change anything for a sleeping node, simply it will be sent to the queue. Will not update into inventory/graph etc., Once it sent successfully to the sleeping node, it will be updated.
I will change this message to user friendly, also I will try to display message queue for a sleeping node.
-
@jkandasa said in MyController 1.2.0-SNAPSHOT version with major provider changes and supports for ack:
I guess the problem will be your node sketch presentation code?
This my presentation codevoid presentation() { sendSketchInfo(SKETCH_NAME, SKETCH_VERSION,true); present(ID_S_MOTION, S_MOTION, "Motion Sensor",true); present(ID_TIME_SLEEP, S_CUSTOM, "Time sleep",true); } void loop() { if(first_start){ first_start = false; DEBUG_PRINTLN("Start"); send(msg_S_MOTION.set(false),true); send(msg_S_MOTION_ARM.set(s_armed),true); //send(msg_TIME_SLEEP.set(time_sleep)); //sendRSSIReport(); //sendBatteryReport(); request(ID_TIME_SLEEP, V_VAR5); //Π·Π°ΠΏΡΠΎΡ Π·Π½Π°ΡΠ΅Π½ΠΈΡ time_sleep```
This all sketch
/******************************************************************* * DEFINE SECTION ********************************************************************/ // Enable debug prints //#define MY_DEBUG #define SER_DEBUG #ifdef SER_DEBUG #define DEBUG_SERIAL(x) Serial.begin(x) #define DEBUG_PRINT(x) Serial.print(x) #define DEBUG_PRINTLN(x) Serial.println(x) #else #define DEBUG_SERIAL(x) #define DEBUG_PRINT(x) #define DEBUG_PRINTLN(x) #endif #define ONE_DAY_TIME 86400000 //24 ΡΠ°ΡΠ° #define ONE_HOUR_TIME 3600000 //1 ΡΠ°Ρ #define MY_SMART_SLEEP_WAIT_DURATION_MS (30000ul) //Π²ΡΠ΅ΠΌΡ ΠΏΡΠΎΡΠ»ΡΡΠΊΠΈ ΡΡΠΈΡΠ° Π΄ΠΎ ΡΡ ΠΎΠ΄Π° Π² ΡΠΎΠ½ #define TIME_SLEEP_INIT 60000 #define RSSI_REPORT_INTERVAL 180000 #define BATTERY_REPORT_INTERVAL 600000 //#define BATTERY_REPORT_INTERVAL ONE_DAY_TIME //#define MY_INDICATION_HANDLER // Enable and select radio type attached //#define MY_RADIO_NRF24 #define MY_RADIO_RFM69 //#define MY_RADIO_RFM95 //#define MY_RADIO_NRF5_ESB #ifdef MY_RADIO_NRF24 //#define SKETCH_NAME "nrf24 gate" #define MY_RF24_PA_LEVEL (RF24_PA_MAX) #define MY_RF24_CHANNEL (124) //#define MY_RF24_CHANNEL (125) #endif #ifdef MY_RADIO_RFM69 //#define SKETCH_NAME "rfm69 gate" #define MY_IS_RFM69HW #define MY_RFM69_NEW_DRIVER // ATC on RFM69 works only with the new driver (not compatible with old=default driver) #define MY_RFM69_ATC_MODE_ENABLED #define MY_RFM69_ATC_TARGET_RSSI_DBM (-70) // target RSSI -70dBm #define MY_RFM69_MAX_POWER_LEVEL_DBM (20) // max. TX power 10dBm = 10mW //#define MY_DEBUG_VERBOSE_RFM69 //#define MY_RFM69_ENABLE_ENCRYPTION #endif //**** Message signing settings /*#define MY_SIGNING_SOFT #define MY_SIGNING_SOFT_RANDOMSEED_PIN 7 #define MY_SIGNING_REQUEST_SIGNATURES*/ #ifdef MY_RADIO_RFM95 //#define SKETCH_NAME "rfm95 gate" #define MY_RFM95_FREQUENCY RFM95_434MHZ //#define MY_TRANSPORT_STATE_TIMEOUT_MS (3*1000ul) //#define RFM95_RETRY_TIMEOUT_MS (3000ul) //#define MY_RFM95_MODEM_CONFIGRUATION RFM95_BW125CR48SF4096 #define MY_RFM95_MODEM_CONFIGRUATION RFM95_BW125CR45SF128 #define MY_RFM95_ATC_TARGET_RSSI_DBM (-70) // target RSSI -70dBm #define MY_RFM95_MAX_POWER_LEVEL_DBM (30) // max. TX power 30dBm = 1000mW #endif #ifdef MY_RADIO_NRF5_ESB //#define SKETCH_NAME "nrf5 gate" #endif #if defined(MY_RADIO_RFM69) || defined(MY_RADIO_RFM95) #define MY_SIGNAL_REPORT_ENABLED #define MY_DEFAULT_RX_LED_PIN LED_BUILTIN #endif // Set baud rate to same as optibot #define MY_BAUD_RATE 9600 #define MY_NODE_ID 3 #define SKETCH_NAME "Motion Sensor" #define SKETCH_VERSION "1.0" #define ID_S_MOTION 1 // Id of the sensor child #define ID_TIME_SLEEP 2 #define ID_RSSI 3 #define PIN_S_MOTION 3 // The digital input you attached your motion sensor. (Only 2 and 3 generates interrupt!) #define PIN_PWR 4 // Pin for power sensors in sleep. #define VCC_MIN 2.7 #define VCC_MAX 3.9 #include <MySensors.h> #include <Vcc.h> Vcc vcc; /* //ΠΡΠΏΡΠ°Π²ΠΈΡΡ ΡΡΠΎΠ²Π΅Π½Ρ Π±Π°ΡΠ°ΡΠ΅ΠΈ ΠΏΠΎΡΠ»Π΅ ΡΡΠΎΠ»ΡΠΊΠΈΡ ΡΠΈΠΊΠ»ΠΎΠ² ΠΏΠ΅ΡΠ΅Π΄Π°Ρ.ΠΠ°ΠΊΡΠΈΠΌΠ°Π»ΡΠ½ΡΠΉ ΠΈΠ½ΡΠ΅ΡΠ²Π°Π» ΠΎΡΡΠ΅ΡΠ° ΡΠ°ΠΊΠΆΠ΅ Π±ΡΠ΄Π΅Ρ ΡΠ°Π²Π΅Π½ ΡΡΠΎΠΌΡ ΠΊΠΎΠ»ΠΈΡΠ΅ΡΡΠ²Ρ Π΄Π½Π΅ΠΉ. int BATTERY_REPORT_BY_IRT_CYCLE = 10; // "false" will make the first loop disregard high output from HV-505 (from start-up) and make a battery report instead. bool interruptReturn = false; */ #if defined(MY_RADIO_RFM69) || defined(MY_RADIO_RFM95) MyMessage msg_RSSI(ID_RSSI,V_VAR5);//Π‘ΠΎΠ·Π΄Π°Π΅ΠΌ ΠΊΠΎΠ½ΡΠ΅ΠΉΠ½Π΅Ρ Π΄Π»Ρ ΠΈΠ·ΠΌΠ΅ΡΠΈΡΠ΅Π»Ρ RSSI #endif MyMessage msg_S_MOTION(ID_S_MOTION, V_TRIPPED);// Π‘ΠΎΠ·Π΄Π°Π΅ΠΌ ΠΊΠΎΠ½ΡΠ΅ΠΉΠ½Π΅Ρ Π΄Π»Ρ Π΄Π°ΡΡΠΈΠΊΠ° MyMessage msg_S_MOTION_ARM(ID_S_MOTION, V_ARMED);// Π‘ΠΎΠ·Π΄Π°Π΅ΠΌ ΠΊΠΎΠ½ΡΠ΅ΠΉΠ½Π΅Ρ Π΄Π»Ρ Π΄Π°ΡΡΠΈΠΊΠ° MyMessage msg_TIME_SLEEP(ID_TIME_SLEEP, V_VAR5); bool first_start; bool s_armed; //ΡΠ΅ΠΆΠΈΠΌ ΡΠ°Π±ΠΎΡΡ ΡΠ΅Π½ΡΠΎΡΠ° - armed, bypassed unsigned long time_sleep; unsigned long lastSendRSSI = 0; unsigned long lastSendBattery = 0; unsigned long millis_in_sleep = 0; unsigned long millis_total = 0; int sleep_returt; void setup() { DEBUG_PRINTLN("Setup"); first_start = true; s_armed = true; time_sleep = TIME_SLEEP_INIT; pinMode(PIN_PWR, OUTPUT);//ΠΠΈΠ½ ΠΏΠΈΡΠ°ΡΡΠΈΠΉ Π΄Π°ΡΡΠΈΠΊΠΈ digitalWrite(PIN_PWR, HIGH); pinMode(PIN_S_MOTION, INPUT); // ΠΡ ΠΎΠ΄ Π΄Π°ΡΡΠΈΠΊΠ° //digitalWrite(PIN_S_DOOR, HIGH); //ΠΏΠΎΠ΄ΡΡΠΆΠΊΠ° ΠΊ ΠΏΠ»ΡΡΡ Π΄Π»Ρ ΠΎΡΠ»Π°Π΄ΠΊΠΈ } void presentation() { sendSketchInfo(SKETCH_NAME, SKETCH_VERSION,true); present(ID_S_MOTION, S_MOTION, "Motion Sensor",true); present(ID_TIME_SLEEP, S_CUSTOM, "Time sleep",true); } void loop() { if(first_start){ first_start = false; DEBUG_PRINTLN("Start"); send(msg_S_MOTION.set(false),true); send(msg_S_MOTION_ARM.set(s_armed),true); //send(msg_TIME_SLEEP.set(time_sleep)); //sendRSSIReport(); //sendBatteryReport(); request(ID_TIME_SLEEP, V_VAR5); //Π·Π°ΠΏΡΠΎΡ Π·Π½Π°ΡΠ΅Π½ΠΈΡ time_sleep } millis_total = millis() + millis_in_sleep + MY_SMART_SLEEP_WAIT_DURATION_MS; #if defined(MY_RADIO_RFM69) || defined(MY_RADIO_RFM95) if (millis_total - lastSendRSSI > RSSI_REPORT_INTERVAL) { lastSendRSSI = millis_total; sendRSSIReport(); } #endif if (millis_total - lastSendBattery > BATTERY_REPORT_INTERVAL) { lastSendBattery = millis_total; sendBatteryReport(); } //sendHeartbeat(); sleep_returt = sleep(digitalPinToInterrupt(PIN_S_MOTION),CHANGE,time_sleep,true); if(sleep_returt != MY_WAKE_UP_BY_TIMER){ // ΠΏΡΠΎΡΠ½ΡΠ»ΠΈΡΡ ΠΏΠΎ ΡΡΠ΅Π²ΠΎΠ³Π΅ send(msg_S_MOTION.set(true),true); DEBUG_PRINTLN("Π’Π ΠΠΠΠΠ!!!"); } else{ millis_in_sleep = millis_in_sleep + time_sleep; } DEBUG_PRINT("ts = ");DEBUG_PRINTLN(time_sleep); } /*********************FUNCTIONS**********************************/ //ΡΡΠ½ΠΊΡΠΈΡ ΠΎΠ±ΡΠ°Π±ΠΎΡΠΊΠΈ Π²Ρ ΠΎΠ΄ΡΡΠΈΡ ΡΠΎΠΎΠ±ΡΠ΅Π½ΠΈΠΉ void receive(const MyMessage &message) { if (message.sensor == ID_S_MOTION) { //ΠΏΡΠΎΠ²Π΅ΡΡΠ΅ΠΌ, ΡΡΠΎ ΠΈΠΌΠ΅Π½Π½ΠΎ ΡΡΠΎΠΌΡ ΡΠ΅Π½ΡΠΎΡΡ if (message.type == V_ARMED) { //ΠΏΡΠΎΠ²Π΅ΡΡΠ΅ΠΌ ΡΠΈΠΏ ΠΏΠ΅ΡΠ΅ΠΌΠ΅Π½Π½ΠΎΠΉ s_armed = message.getBool(); //ΠΏΠΎΠ»ΡΡΠ°Π΅ΠΌ Π·Π½Π°ΡΠ΅Π½ΠΈΠ΅ V_ARMED DEBUG_PRINT("V_ARMED received: ");DEBUG_PRINTLN(s_armed); if(s_armed){ DEBUG_PRINTLN("Power On"); digitalWrite(PIN_PWR, HIGH); //Π²ΠΊΠ»ΡΡΠ°Π΅ΠΌ ΠΏΠΈΡΠ°Π½ΠΈΠ΅ //digitalWrite(PIN_PWR, LOW); //Π΄Π»Ρ ΠΎΡΠ»Π°Π΄ΠΊΠΈ } else{ DEBUG_PRINTLN("Power Off"); digitalWrite(PIN_PWR, LOW); //ΠΎΡΠΊΠ»ΡΡΠ°Π΅ΠΌ ΠΏΠΈΡΠ°Π½ΠΈΠ΅ //digitalWrite(PIN_PWR, HIGH); //Π΄Π»Ρ ΠΎΡΠ»Π°Π΄ΠΊΠΈ } } } else if (message.sensor == ID_TIME_SLEEP){ if (message.type == V_VAR5) { time_sleep = message.getULong(); //ΠΏΠΎΠ»ΡΡΠ°Π΅ΠΌ Π·Π½Π°ΡΠ΅Π½ΠΈΠ΅ sleep_time DEBUG_PRINT("time_sleep = ");DEBUG_PRINTLN(time_sleep); } } } //ΡΡΠ½ΠΊΡΠΈΡ ΠΎΡΠΏΡΠ°Π²ΠΊΠΈ RSSI Π΅ΡΠ»ΠΈ ΠΈΡΠΏΠΎΠ»ΡΠ·ΡΠ΅ΠΌ RFM69 ΡΠ°Π΄ΠΈΠΎ #if defined(MY_RADIO_RFM69) || defined(MY_RADIO_RFM95) void sendRSSIReport() { int16_t rssiVal; char rssiStr[14]; rssiVal = transportGetSignalReport(SR_RX_RSSI); // snprintf(rssiStr,10,"rssi: %d%",rssiVal,"dBm"); sprintf (rssiStr, "rssi:%d dBm", rssiVal); send(msg_RSSI.set(rssiStr),true); DEBUG_PRINTLN(rssiStr); //DEBUG_PRINT("TxRssi = ");DEBUG_PRINTLN(transportGetSignalReport(SR_TX_RSSI)); } #endif //ΡΡΠ½ΠΊΡΠΈΡ ΠΎΡΠΏΡΠ°Π²ΠΊΠΈ ΠΎΡΡΠ΅ΡΠ° ΡΠΎΡΡΠΎΡΠ½ΠΈΡ Π±Π°ΡΠ°ΡΠ΅ΠΈ void sendBatteryReport() { float p = vcc.Read_Perc(VCC_MIN, VCC_MAX, true); int batteryPcnt = static_cast<int>(p); sendBatteryLevel(batteryPcnt,true); DEBUG_PRINT("Battery is: ");DEBUG_PRINTLN(batteryPcnt); }
I can not find an error yet. I'll look further.
-
@wanvo Is this sketch running first time with MyController? Do you have this sketch with the previous version? Did it work with old version?
Can you add some minimal delay between,
send(msg_S_MOTION.set(false),true); wait(500); // value in milliseconds send(msg_S_MOTION_ARM.set(s_armed),true);