• Register
    • Login
    • Search
    • Categories
    • Recent
    • Tags
    • Popular

    Post Webhook Handler Error

    Troubleshooting
    2
    3
    676
    Loading More Posts
    • Oldest to Newest
    • Newest to Oldest
    • Most Votes
    Reply
    • Reply as topic
    Log in to reply
    This topic has been deleted. Only users with topic management privileges can see it.
    • G
      giuseppez last edited by

      Trying to schedule a pair of webhooks, to just understand their functioning, I presume to have encountered an error.
      If you look a the following golang module:
      https://github.com/mycontroller-org/server/blob/master/plugin/handler/webhook/handler.go
      and locate the Post function:

      // Post handler implementation
      func (c *WebhookClient) Post(data map[string]interface{}) error {
      

      you can see that there is a loop on all the configured handler parameters. In my case I configured two:

      webook.PNG

      but only one is executed because, after its inovocation, you can find this code:

      		if err != nil {
      			zap.L().Error("error on webhook handler call", zap.Int("responseStatusCode", responseCode), zap.Error(err))
      		}
      		return err
      

      In my opinion the return statement should stay inside the curl brackets in this way:

      		if err != nil {
      			zap.L().Error("error on webhook handler call", zap.Int("responseStatusCode", responseCode), zap.Error(err))
      		        return err
      		}
      
      

      to avoid to return to parent function before finishing the loop.

      jkandasa 1 Reply Last reply Reply Quote 1
      • jkandasa
        jkandasa @giuseppez last edited by

        HI @giuseppez thanks to report this issue and root cause of the error.
        I have fixed it as you mentioned. Please try with the recent build

        https://github.com/mycontroller-org/server/commit/ad667fd2ec29ad7bc8b1e558a8b36752f519eecd

        G 1 Reply Last reply Reply Quote 0
        • G
          giuseppez @jkandasa last edited by

          Hi @jkandasa thank you very much.

          1 Reply Last reply Reply Quote 0
          • First post
            Last post

          0
          Online

          647
          Users

          506
          Topics

          3.3k
          Posts

          Copyright © 2015-2022 MyController.org | Contributors | Localization